Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: replace airtap with wtr #1722

Merged
merged 22 commits into from
Nov 7, 2023
Merged

chore: replace airtap with wtr #1722

merged 22 commits into from
Nov 7, 2023

Conversation

robertsLando
Copy link
Member

Fixes #1655

@robertsLando robertsLando marked this pull request as draft October 24, 2023 15:52
@codecov
Copy link

codecov bot commented Oct 30, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (92a9646) 81.03% compared to head (7539c3f) 81.03%.

❗ Current head 7539c3f differs from pull request most recent head f636e88. Consider uploading reports for the commit f636e88 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1722   +/-   ##
=======================================
  Coverage   81.03%   81.03%           
=======================================
  Files          21       21           
  Lines        1366     1366           
  Branches      323      323           
=======================================
  Hits         1107     1107           
  Misses        182      182           
  Partials       77       77           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@robertsLando robertsLando marked this pull request as ready for review October 30, 2023 08:53
@robertsLando
Copy link
Member Author

@BertKleewein @vishnureddy17 @mcollina This has been painful but I think worth it. Now browser tests are much better, they will run on chromium, firefox and webkit using both ws and wss 🎉

@robertsLando robertsLando merged commit 85e19b1 into main Nov 7, 2023
6 checks passed
@robertsLando robertsLando deleted the web-test-runner branch November 7, 2023 09:23
@vishnureddy17
Copy link
Member

Amazing work, thank you!

@robertsLando
Copy link
Member Author

Another long awaited change is: #1731

This will also make tests with wtr more streightforward as it only support esm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace airtap with wtr
2 participants