fix and test for issue 252 (retry) #256
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I just tested it by manually changing the 3 lines in the client.js by hand, it worked in my project. This should definitely fix issue #252. Haven't tested the test, though. |
mcollina
added a commit
that referenced
this pull request
Feb 28, 2015
fix and test for issue 252 (retry)
|
Thank so much! A new release is coming :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
2nd try first request build failed... added one last change . Test seems to be effective at catching problem without fix, but did not see offline event as expected to fail the test. Instead when it fails the test just times out.