Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecation Warning #63

Closed
muz3 opened this issue Jul 26, 2019 · 2 comments
Closed

Deprecation Warning #63

muz3 opened this issue Jul 26, 2019 · 2 comments

Comments

@muz3
Copy link
Contributor

muz3 commented Jul 26, 2019

hi team, I received the following warning on my app build, after tracing it down, I found out mqtt-packet still uses Buffer() here "https://github.com/mqttjs/mqtt-packet/blob/master/constants.js#L131". Can we please get it fixed? thanks,

"(node:8008) [DEP0005] DeprecationWarning: Buffer() is deprecated due to security and usability issues. Please use the Buffer.alloc(), Buffer.allocUnsafe(), or Buffer.from() methods instead."

@mcollina
Copy link
Member

mcollina commented Jul 26, 2019 via email

@muz3
Copy link
Contributor Author

muz3 commented Jul 27, 2019

done. PR is submitted here: #64

changed from 'new Buffer(1)' to Buffer.alloc(1). no more deprecated warning, and passed npm test.

@mcollina mcollina closed this as completed Sep 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants