fix: buffer is not defined in browser #128
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
Buffer is an API in Node.js and does not exist in browsers. When upgrading to webpack 5, webpack will no longer automatically bundles core node modules (buffer/process etc.). Which will cause the
Buffer is not defined
problems.mqttjs/MQTT.js#1412
mqttjs/MQTT.js#1338
Solutions
webpack.config.js
file. But there are also some scenarios where thewebpack.config.js
cannot be modified (such as the Openharmony development environment I‘m using).