Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adopted safe-buffer #27

Merged
merged 1 commit into from
Apr 7, 2017
Merged

Adopted safe-buffer #27

merged 1 commit into from
Apr 7, 2017

Conversation

mcollina
Copy link
Member

@mcollina mcollina commented Apr 7, 2017

Also, updated standard to 10.0.0

@mcollina mcollina requested a review from wuhkuh April 7, 2017 11:33
wuhkuh
wuhkuh approved these changes Apr 7, 2017
View reviewed changes
Copy link
Member

@wuhkuh wuhkuh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

We can choose to switch back to the Node API by 2018-04-01, which is the date Node 4.x.x LTS support ends and this problem with it.

@mcollina mcollina merged commit fef6b49 into master Apr 7, 2017
@mcollina mcollina deleted the safe-buffer branch April 7, 2017 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wuhkuh wuhkuh wuhkuh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mcollina @wuhkuh