Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add cross-mark #2

Closed
wants to merge 1 commit into from
Closed

Add cross-mark #2

wants to merge 1 commit into from

Conversation

mr0re1
Copy link
Owner

@mr0re1 mr0re1 commented Apr 5, 2023

Submission Checklist

  • Have you installed and run this change against pre-commit? (pre-commit install)
  • Are all tests passing? (make tests)
  • Have you written unit tests to cover this change?
  • Is unit test coverage still above 80%?
  • Have you updated all applicable documentation?
  • Have you followed the guidelines in our Contributing document?

mr0re1 added a commit that referenced this pull request Oct 21, 2023
@mr0re1
Augment expression parsing error with position
8a84181 
* Augment expression parsing error with position;
* Remove `YAML parsing error: ` prefix.

```yaml
vars:
  project_id: $(6 + 4) # Case #1
  hello: ((world+))    # Case #2
```

```sh
YAML parsing error: only traversal expressions are supported, got "6 + 4"
YAML parsing error: :0,6-6: Missing expression; Expected the start of an expression, but found the end of the file.

Case #1
Error: only traversal expressions are supported, got "6 + 4"
2:   project_id: $(6 + 4)
Case #2
Error: :0,6-6: Missing expression; Expected the start of an expression, but found the end of the file.
2:   hello: ((world+))
```
mr0re1 added a commit that referenced this pull request Oct 26, 2023
@mr0re1
Augment expression parsing error with position
5810455 
* Augment expression parsing error with position;
* Remove `YAML parsing error: ` prefix.

```yaml
vars:
  project_id: $(6 + 4) # Case #1
  hello: ((world+))    # Case #2
```

```sh
YAML parsing error: only traversal expressions are supported, got "6 + 4"
YAML parsing error: :0,6-6: Missing expression; Expected the start of an expression, but found the end of the file.

Case #1
Error: only traversal expressions are supported, got "6 + 4"
2:   project_id: $(6 + 4)
Case #2
Error: :0,6-6: Missing expression; Expected the start of an expression, but found the end of the file.
2:   hello: ((world+))
```
mr0re1 added a commit that referenced this pull request Oct 26, 2023
@mr0re1
Augment expression parsing error with position (GoogleCloudPlatform#1887
882a913 
)

* Augment expression parsing error with position;
* Remove `YAML parsing error: ` prefix.

```yaml
vars:
  project_id: $(6 + 4) # Case #1
  hello: ((world+))    # Case #2
```

```sh
YAML parsing error: only traversal expressions are supported, got "6 + 4"
YAML parsing error: :0,6-6: Missing expression; Expected the start of an expression, but found the end of the file.

Case #1
Error: only traversal expressions are supported, got "6 + 4"
2:   project_id: $(6 + 4)
Case #2
Error: :0,6-6: Missing expression; Expected the start of an expression, but found the end of the file.
2:   hello: ((world+))
```
@mr0re1 mr0re1 closed this Mar 12, 2024
@mr0re1 mr0re1 deleted the mockdev_pr branch March 12, 2024 22:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@mr0re1