update: Compatibility with Halo2 0.4 and Halo2curves 0.7

mratsim · Sep 25, 2024 · b89135e · b89135e
1 parent b850dc7
commit b89135e
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 7 deletions.
diff --git a/constantine-rust/constantine-halo2-zal/benches/msm.rs b/constantine-rust/constantine-halo2-zal/benches/msm.rs
@@ -17,7 +17,7 @@ use constantine_halo2_zal::CttEngine;
 
 use halo2curves::bn256::{Fr as Scalar, G1Affine as Point};
 use halo2curves::ff::Field;
-use halo2curves::msm::best_multiexp;
+use halo2curves::msm::msm_best;
 use halo2curves::zal::MsmAccel;
 
 use rayon::current_thread_index;
@@ -94,7 +94,7 @@ fn msm(c: &mut Criterion) {
                 assert!(k < 64);
                 let n: usize = 1 << k;
                 b.iter(|| {
-                    best_multiexp(&coeffs[..n], &bases[..n]);
+                    msm_best(&coeffs[..n], &bases[..n]);
                 })
             })
             .sample_size(SAMPLE_SIZE);

diff --git a/constantine-rust/constantine-halo2-zal/tests/t_zal_msm_accel.rs b/constantine-rust/constantine-halo2-zal/tests/t_zal_msm_accel.rs
@@ -16,7 +16,7 @@ use halo2_middleware::halo2curves::bn256;
 use halo2_middleware::halo2curves::ff::Field;
 use halo2_middleware::halo2curves::group::prime::PrimeCurveAffine;
 use halo2_middleware::halo2curves::group::{Curve, Group};
-use halo2_middleware::halo2curves::msm::best_multiexp;
+use halo2_middleware::halo2curves::msm::msm_best;
 use halo2_middleware::zal::traits::MsmAccel;
 
 #[test]
@@ -42,7 +42,7 @@ fn run_msm_zal(min_k: usize, max_k: usize) {
         let scalars = &scalars[..1 << k];
 
         let t0 = start_timer!(|| format!("freestanding msm k={}", k));
-        let e0 = best_multiexp(scalars, points);
+        let e0 = msm_best(scalars, points);
         end_timer!(t0);
 
         let engine = CttEngine::new(hardware::get_num_threads_os());

diff --git a/docs/zk_accel_layer.md b/docs/zk_accel_layer.md
@@ -155,7 +155,7 @@ mod tests {
     use halo2curves::ff::Field;
     use halo2curves::group::prime::PrimeCurveAffine;
     use halo2curves::group::{Curve, Group};
-    use halo2curves::msm::best_multiexp;
+    use halo2curves::msm::msm_best;
     use halo2curves::zal::MsmAccel;
 
     #[test]
@@ -181,7 +181,7 @@ mod tests {
             let scalars = &scalars[..1 << k];
 
             let t0 = start_timer!(|| format!("freestanding msm k={}", k));
-            let e0 = best_multiexp(scalars, points);
+            let e0 = msm_best(scalars, points);
             end_timer!(t0);
 
             let engine = CttEngine::new(num_cpus::get());
@@ -232,4 +232,4 @@ mod tests {
         prj.z *= jac.z
       ```
       Coordinates are ordered (X, Y, Z)
-    - Result requires 96 bytes
+    - Result requires 96 bytes