Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow installation / import through nimble #281

Merged
merged 2 commits into from
Oct 16, 2023
Merged

Allow installation / import through nimble #281

merged 2 commits into from
Oct 16, 2023

Conversation

mratsim
Copy link
Owner

@mratsim mratsim commented Oct 15, 2023

By default, nimble strips anything not named constantine but we need metering as well.

This adapt the nimble file to allow this.

Note: the current directory structure was chosen after careful consideration to market across devs looking for different capabilities in cryptographic backend. Metering is a particularly valuable niche to optimize EVM gas costs hence it SHOULD be "in-your-face" in the directory structure.

We might also want to consider installing the binding generators, but it's unsure if there is a command (maybe nimble build?) to build Constantine as a static or shared library. Though that might not be needed in the future with incremental compilation.

Lastly we might also consider installing the tests so they can be run on constantine install, it's especially important given unique codepaths for 32/64-bit, CPU ISAs and OS combination.

@nayr7
Copy link

nayr7 commented Oct 16, 2023

I'm not sure if this is the right place to ask (sorry if it's not) but is there any interest to make constantine/threadpool into it's own nimble package like Weave and nim-taskpools ? I am not sure if there are technical hurdles that prevents this (for example shared code between the threading and cryptographic part) or if it's just a lack of interest. I personally think there might be some merit to be able to use constantine's threadpool without bringing in the all the crypto baggage with it. Also thanks for your work ! :)

@mratsim mratsim merged commit 34baa74 into master Oct 16, 2023
12 checks passed
@mratsim mratsim deleted the please-nimble branch October 17, 2023 21:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants