C & Rust elliptic bindings: batchAffine, scalarMul, serial MSM and 32-bit Rust bindings #332
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Seems like there is a Nim v2 codegen bug with {.noInit.} in templates. The ` should be mangled as X60 but here it is not
Trying a simple repro doesn't work so there is probably a generic sandwich class bug involved nim-lang/Nim#11225. Removing noInit fixes the issue. |
mratsim
added a commit
that referenced
this pull request
Jan 10, 2024
mratsim
added a commit
that referenced
this pull request
Jan 11, 2024
* c-api: add scalar mul on G1 and G2 - followup #332 * add conversion/codecs procs between bigints and field elements * update Rust bindings
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Missing C and Rust bindings
cc @Armantidas @sauliusgrigaitis
#331 will be rebased on top after merge.