Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make_lib_rust - use position independent code #334

Merged
merged 2 commits into from
Jan 9, 2024

Conversation

lynxcs
Copy link
Contributor

@lynxcs lynxcs commented Jan 7, 2024

added -fPIC when using make_lib_rust, since rust already does that by default.

This change is required by rust-kzg constantine backend to make c-kzg-4844 bindings work.

@mratsim if enabling for all rust builds is not acceptable, I can also add as optional feature in Cargo.toml & change how it's passed in build.rs

I am not familiar with Nim so if there's a better/more preferred way of doing this lmk, will be happy to fix.

mratsim
mratsim previously approved these changes Jan 9, 2024
Copy link
Owner

@mratsim mratsim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

I would have done something similar.

@mratsim mratsim enabled auto-merge (squash) January 9, 2024 07:52
@mratsim mratsim merged commit 89d32a9 into mratsim:master Jan 9, 2024
16 checks passed
@lynxcs lynxcs deleted the rust-kzg-changes branch January 9, 2024 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants