EC: Scalar mul accepts scalar as field element as well as bigint #370
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mratsim
added a commit
that referenced
this pull request
Apr 27, 2024
|
It seems like there is a regression in Nim 2.0.x devel branch that breaks type-checking:
No issue in Nim 2.0.2
Edit: or Nim 2.0.4 Investigation moved to #373 |
mratsim
force-pushed
the
scalarmul-for-field-scalar
branch
from
7b5d3e1
to
42efaaf
Compare
mratsim
added a commit
that referenced
this pull request
Apr 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously Constantine required to convert scalar input of scalar mul to bigint every-time before calling.
This does not refactor eth-verkle-ipa. It will be done in a second time.