Go API for EVM precompiles #385
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mratsim
reviewed
Jun 9, 2024
|
|
||
| // Ethereum BLS signatures | ||
| // ----------------------------------------------------- |
There was a problem hiding this comment.
I think this needs a rebase on master as this should already be there from #383
|
Woops, guess I screwed up the rebase I did. Will investigate. |
This makes sure that we never try to access arg[0] for an empty slice.
Vindaar
commented
Jun 12, 2024
Comment on lines
+1420
to
+1450
| testDirEvm = "../tests/protocol_ethereum_evm_precompiles/" | ||
|
|
||
| modexp_tests = filepath.Join(testDirEvm, "modexp.json") | ||
| modexp_eip2565_tests = filepath.Join(testDirEvm, "modexp_eip2565.json") | ||
|
|
||
| bn256Add_tests = filepath.Join(testDirEvm, "bn256Add.json") | ||
| bn256ScalarMul_tests = filepath.Join(testDirEvm, "bn256ScalarMul.json") | ||
| bn256Pairing_tests = filepath.Join(testDirEvm, "bn256Pairing.json") | ||
|
|
||
| add_G1_bls_tests = filepath.Join(testDirEvm, "eip-2537/add_G1_bls.json") | ||
| fail_add_G1_bls_tests = filepath.Join(testDirEvm, "eip-2537/fail-add_G1_bls.json") | ||
| add_G2_bls_tests = filepath.Join(testDirEvm, "eip-2537/add_G2_bls.json") | ||
| fail_add_G2_bls_tests = filepath.Join(testDirEvm, "eip-2537/fail-add_G2_bls.json") | ||
|
|
||
| mul_G1_bls_tests = filepath.Join(testDirEvm, "eip-2537/mul_G1_bls.json") | ||
| fail_mul_G1_bls_tests = filepath.Join(testDirEvm, "eip-2537/fail-mul_G1_bls.json") | ||
| mul_G2_bls_tests = filepath.Join(testDirEvm, "eip-2537/mul_G2_bls.json") | ||
| fail_mul_G2_bls_tests = filepath.Join(testDirEvm, "eip-2537/fail-mul_G2_bls.json") | ||
|
|
||
| multiexp_G1_bls_tests = filepath.Join(testDirEvm, "eip-2537/multiexp_G1_bls.json") | ||
| fail_multiexp_G1_bls_tests = filepath.Join(testDirEvm, "eip-2537/fail-multiexp_G1_bls.json") | ||
| multiexp_G2_bls_tests = filepath.Join(testDirEvm, "eip-2537/multiexp_G2_bls.json") | ||
| fail_multiexp_G2_bls_tests = filepath.Join(testDirEvm, "eip-2537/fail-multiexp_G2_bls.json") | ||
|
|
||
| pairing_check_bls_tests = filepath.Join(testDirEvm, "eip-2537/pairing_check_bls.json") | ||
| fail_pairing_check_bls_tests = filepath.Join(testDirEvm, "eip-2537/fail-pairing_check_bls.json") | ||
|
|
||
| map_fp_to_G1_bls_tests = filepath.Join(testDirEvm, "eip-2537/map_fp_to_G1_bls.json") | ||
| fail_map_fp_to_G1_bls_tests = filepath.Join(testDirEvm, "eip-2537/fail-map_fp_to_G1_bls.json") | ||
| map_fp2_to_G2_bls_tests = filepath.Join(testDirEvm, "eip-2537/map_fp2_to_G2_bls.json") | ||
| fail_map_fp2_to_G2_bls_tests = filepath.Join(testDirEvm, "eip-2537/fail-map_fp2_to_G2_bls.json") |
There was a problem hiding this comment.
Tabs are annoying. With 4 space width equivalent tabs the lines are aligned on the =...
mratsim
approved these changes
Jun 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This continues from #383 by porting over the EVM precompiles C API into Go. All test cases are ported from Nim and should all pass.