PR #330 - enable test verkle ipa #389
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mratsim
changed the title
|
Bisecting, the regression mentioned in #330 (comment) is due to #371 |
mratsim
force-pushed
the
pr330_enable_test_verkle_ipa
branch
from
44bd3a3
to
dc2084f
Compare
|
Confirmed that Windows failure without any error is due to a stack overflow due to The temporary workaround is to use a ref array, see bc74902. Ultimately those should be replaced by using Constantine allocator functions, to avoid Nim allocator, see: #367 Strangely, if changing to a ref alloc in the test file, the Multiproof creation and verification test fails. Hopefully switching 1 out of 2 to heap space leaves enough stack space for Windows test. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is #330, rebased to latest master and for investigation of CI failure on Windows