Elliptic Curve: ⚠️ breaking❗ rename isInf/setinf to isNeutral/setNeutral and rename generator #399
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jun 26, 2024
This was referenced Jul 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is breaking internal API and curves_primitives API.
It:
generatortosetGenerator, this has been introduced yesterday in 8ac73c7 so unlikely to cause external breakage.isInf/setInftoisNeutral/setNeutralwhich external libraries might rely on. The transition is just a find/replace.Rationale
isInf/setInfare for points at infinity which are technically not on the elliptic curve. But in Constantine it is also conflated with the identity/neutral element.This is true for short Weierstrass curves but not true for Twisted Edwards curves as the neutral elements ARE on the curve.
To allow generic algorithm like scalar multiplication and multi-scalar-mul, we rename everything to
isNeutral/setNeutral