Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(MSM - #366): edge case when scalar bits are divided by MSM 'c' parameter #410

Merged
merged 2 commits into from
Jun 28, 2024

Conversation

mratsim
Copy link
Owner

@mratsim mratsim commented Jun 28, 2024

This fixes #366

Here is the sequence of events.

  • 22529 input coefficients of size 254 bits
  • After endomorphism computation, they are transformed into 90116 coefficients of size 65 bits
  • 90116 maps to an MSM parameter c of 13
  • 13 divides 65 exactly and triggers a bug where 1 mini-MSM iteration is missing.

@mratsim mratsim merged commit ee818f0 into master Jun 28, 2024
24 checks passed
@mratsim mratsim deleted the fix-366 branch June 28, 2024 21:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Another G2 MSM wrong result
1 participant