Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

workaround #448: deactivated secp256k1 tests due to bug on Windows with assembly #449

Merged
merged 2 commits into from
Aug 1, 2024
Merged

workaround #448: deactivated secp256k1 tests due to bug on Windows with assembly #449

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2220302
workaround #448: deactivated secp256k1 tests due to bug on Windows wi…
mratsim Jul 31, 2024
a55345a
workaround #448: missed one
mratsim Jul 31, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion constantine.nimble
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -529,7 +529,7 @@ const testDesc: seq[tuple[path: string, useGMP: bool]] = @[
("tests/math_elliptic_curves/t_ec_sage_bls12_381.nim", false),
("tests/math_elliptic_curves/t_ec_sage_pallas.nim", false),
("tests/math_elliptic_curves/t_ec_sage_vesta.nim", false),
("tests/math_elliptic_curves/t_ec_sage_secp256k1.nim", false),
# ("tests/math_elliptic_curves/t_ec_sage_secp256k1.nim", false),

# Edge cases highlighted by past bugs
# ----------------------------------------------------------
Expand Down
20 changes: 10 additions & 10 deletions tests/math_elliptic_curves/t_ec_shortw_jac_g1_add_double.nim
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,11 +22,11 @@ run_EC_addition_tests(
moduleName = "test_ec_shortweierstrass_jacobian_g1_add_double_" & $BN254_Snarks
)

run_EC_addition_tests(
ec = EC_ShortW_Jac[Fp[Secp256k1], G1],
Iters = Iters,
moduleName = "test_ec_shortweierstrass_jacobian_g1_add_double_" & $Secp256k1
)
# run_EC_addition_tests(
# ec = EC_ShortW_Jac[Fp[Secp256k1], G1],
# Iters = Iters,
# moduleName = "test_ec_shortweierstrass_jacobian_g1_add_double_" & $Secp256k1
# )

run_EC_addition_tests(
ec = EC_ShortW_Jac[Fp[BLS12_381], G1],
Expand Down Expand Up @@ -64,11 +64,11 @@ run_EC_addition_vartime_tests(
moduleName = "test_ec_shortweierstrass_jacobian_g1_add_double_vartime_" & $BN254_Snarks
)

run_EC_addition_vartime_tests(
ec = EC_ShortW_Jac[Fp[Secp256k1], G1],
Iters = Iters,
moduleName = "test_ec_shortweierstrass_jacobian_g1_add_double_vartime_" & $Secp256k1
)
# run_EC_addition_vartime_tests(
# ec = EC_ShortW_Jac[Fp[Secp256k1], G1],
# Iters = Iters,
# moduleName = "test_ec_shortweierstrass_jacobian_g1_add_double_vartime_" & $Secp256k1
# )

run_EC_addition_vartime_tests(
ec = EC_ShortW_Jac[Fp[BLS12_381], G1],
Expand Down
10 changes: 5 additions & 5 deletions tests/math_elliptic_curves/t_ec_shortw_jac_g1_mixed_add.nim
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,11 +23,11 @@ run_EC_mixed_add_impl(
moduleName = "test_ec_shortweierstrass_jacobian_mixed_add_" & $BN254_Snarks
)

run_EC_mixed_add_impl(
ec = EC_ShortW_Jac[Fp[Secp256k1], G1],
Iters = Iters,
moduleName = "test_ec_shortweierstrass_jacobian_mixed_add_" & $Secp256k1
)
# run_EC_mixed_add_impl(
# ec = EC_ShortW_Jac[Fp[Secp256k1], G1],
# Iters = Iters,
# moduleName = "test_ec_shortweierstrass_jacobian_mixed_add_" & $Secp256k1
# )

run_EC_mixed_add_impl(
ec = EC_ShortW_Jac[Fp[BLS12_381], G1],
Expand Down
10 changes: 5 additions & 5 deletions tests/math_elliptic_curves/t_ec_shortw_jac_g1_mul_sanity.nim
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,11 +68,11 @@ suite "Order checks on BN254_Snarks":
bool not ay.isSquare()
bool not ay.sqrt_if_square()

run_EC_mul_sanity_tests(
ec = EC_ShortW_Jac[Fp[Secp256k1], G1],
ItersMul = ItersMul,
moduleName = "test_ec_shortweierstrass_jacobian_g1_mul_sanity_" & $Secp256k1
)
# run_EC_mul_sanity_tests(
# ec = EC_ShortW_Jac[Fp[Secp256k1], G1],
# ItersMul = ItersMul,
# moduleName = "test_ec_shortweierstrass_jacobian_g1_mul_sanity_" & $Secp256k1
# )

run_EC_mul_sanity_tests(
ec = EC_ShortW_Jac[Fp[BLS12_381], G1],
Expand Down
10 changes: 5 additions & 5 deletions tests/math_elliptic_curves/t_ec_shortw_jac_g1_mul_vs_ref.nim
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,11 +23,11 @@ run_EC_mul_vs_ref_impl(
moduleName = "test_ec_shortweierstrass_jacobian_g1_mul_vs_ref_" & $BN254_Snarks
)

run_EC_mul_vs_ref_impl(
ec = EC_ShortW_Jac[Fp[Secp256k1], G1],
ItersMul = ItersMul,
moduleName = "test_ec_shortweierstrass_jacobian_g1_mul_vs_ref_" & $Secp256k1
)
# run_EC_mul_vs_ref_impl(
# ec = EC_ShortW_Jac[Fp[Secp256k1], G1],
# ItersMul = ItersMul,
# moduleName = "test_ec_shortweierstrass_jacobian_g1_mul_vs_ref_" & $Secp256k1
# )

run_EC_mul_vs_ref_impl(
ec = EC_ShortW_Jac[Fp[BLS12_381], G1],
Expand Down
10 changes: 5 additions & 5 deletions tests/math_elliptic_curves/t_ec_shortw_jacext_g1_add_double.nim
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,11 +22,11 @@ run_EC_addition_tests(
moduleName = "test_ec_shortweierstrass_jacobian_extended_g1_add_double_" & $BN254_Snarks
)

run_EC_addition_tests(
ec = EC_ShortW_JacExt[Fp[Secp256k1], G1],
Iters = Iters,
moduleName = "test_ec_shortweierstrass_jacobian_extended_g1_add_double_" & $Secp256k1
)
# run_EC_addition_tests(
# ec = EC_ShortW_JacExt[Fp[Secp256k1], G1],
# Iters = Iters,
# moduleName = "test_ec_shortweierstrass_jacobian_extended_g1_add_double_" & $Secp256k1
# )

run_EC_addition_tests(
ec = EC_ShortW_JacExt[Fp[BLS12_381], G1],
Expand Down
10 changes: 5 additions & 5 deletions tests/math_elliptic_curves/t_ec_shortw_jacext_g1_mixed_add.nim
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,11 +23,11 @@ run_EC_mixed_add_impl(
moduleName = "test_ec_shortweierstrass_jacobian_extendedmixed_add_" & $BN254_Snarks
)

run_EC_mixed_add_impl(
ec = EC_ShortW_JacExt[Fp[Secp256k1], G1],
Iters = Iters,
moduleName = "test_ec_shortweierstrass_jacobian_extendedmixed_add_" & $Secp256k1
)
# run_EC_mixed_add_impl(
# ec = EC_ShortW_JacExt[Fp[Secp256k1], G1],
# Iters = Iters,
# moduleName = "test_ec_shortweierstrass_jacobian_extendedmixed_add_" & $Secp256k1
# )

run_EC_mixed_add_impl(
ec = EC_ShortW_JacExt[Fp[BLS12_381], G1],
Expand Down
10 changes: 5 additions & 5 deletions tests/math_elliptic_curves/t_ec_shortw_prj_g1_add_double.nim
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,11 +22,11 @@ run_EC_addition_tests(
moduleName = "test_ec_shortweierstrass_projective_g1_add_double_" & $BN254_Snarks
)

run_EC_addition_tests(
ec = EC_ShortW_Prj[Fp[Secp256k1], G1],
Iters = Iters,
moduleName = "test_ec_shortweierstrass_projective_g1_add_double_" & $Secp256k1
)
# run_EC_addition_tests(
# ec = EC_ShortW_Prj[Fp[Secp256k1], G1],
# Iters = Iters,
# moduleName = "test_ec_shortweierstrass_projective_g1_add_double_" & $Secp256k1
# )

run_EC_addition_tests(
ec = EC_ShortW_Prj[Fp[BLS12_381], G1],
Expand Down
10 changes: 5 additions & 5 deletions tests/math_elliptic_curves/t_ec_shortw_prj_g1_mixed_add.nim
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,11 +23,11 @@ run_EC_mixed_add_impl(
moduleName = "test_ec_shortweierstrass_projective_mixed_add_" & $BN254_Snarks
)

run_EC_mixed_add_impl(
ec = EC_ShortW_Prj[Fp[Secp256k1], G1],
Iters = Iters,
moduleName = "test_ec_shortweierstrass_projective_mixed_add_" & $Secp256k1
)
# run_EC_mixed_add_impl(
# ec = EC_ShortW_Prj[Fp[Secp256k1], G1],
# Iters = Iters,
# moduleName = "test_ec_shortweierstrass_projective_mixed_add_" & $Secp256k1
# )

run_EC_mixed_add_impl(
ec = EC_ShortW_Prj[Fp[BLS12_381], G1],
Expand Down
10 changes: 5 additions & 5 deletions tests/math_elliptic_curves/t_ec_shortw_prj_g1_mul_distri.nim
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,11 +23,11 @@ run_EC_mul_distributive_tests(
moduleName = "test_ec_shortweierstrass_projective_g1_mul_distributive_" & $BN254_Snarks
)

run_EC_mul_distributive_tests(
ec = EC_ShortW_Prj[Fp[Secp256k1], G1],
ItersMul = ItersMul,
moduleName = "test_ec_shortweierstrass_projective_g1_mul_distributive_" & $Secp256k1
)
# run_EC_mul_distributive_tests(
# ec = EC_ShortW_Prj[Fp[Secp256k1], G1],
# ItersMul = ItersMul,
# moduleName = "test_ec_shortweierstrass_projective_g1_mul_distributive_" & $Secp256k1
# )

run_EC_mul_distributive_tests(
ec = EC_ShortW_Prj[Fp[BLS12_381], G1],
Expand Down
10 changes: 5 additions & 5 deletions tests/math_elliptic_curves/t_ec_shortw_prj_g1_mul_sanity.nim
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,11 +67,11 @@ suite "Order checks on BN254_Snarks":
bool not ay.isSquare()
bool not ay.sqrt_if_square()

run_EC_mul_sanity_tests(
ec = EC_ShortW_Prj[Fp[Secp256k1], G1],
ItersMul = ItersMul,
moduleName = "test_ec_shortweierstrass_projective_g1_mul_sanity_" & $Secp256k1
)
# run_EC_mul_sanity_tests(
# ec = EC_ShortW_Prj[Fp[Secp256k1], G1],
# ItersMul = ItersMul,
# moduleName = "test_ec_shortweierstrass_projective_g1_mul_sanity_" & $Secp256k1
# )

run_EC_mul_sanity_tests(
ec = EC_ShortW_Prj[Fp[BLS12_381], G1],
Expand Down
10 changes: 5 additions & 5 deletions tests/math_elliptic_curves/t_ec_shortw_prj_g1_mul_vs_ref.nim
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,11 +23,11 @@ run_EC_mul_vs_ref_impl(
moduleName = "test_ec_shortweierstrass_projective_g1_mul_vs_ref_" & $BN254_Snarks
)

run_EC_mul_vs_ref_impl(
ec = EC_ShortW_Prj[Fp[Secp256k1], G1],
ItersMul = ItersMul,
moduleName = "test_ec_shortweierstrass_projective_g1_mul_vs_ref_" & $BN254_Snarks
)
# run_EC_mul_vs_ref_impl(
# ec = EC_ShortW_Prj[Fp[Secp256k1], G1],
# ItersMul = ItersMul,
# moduleName = "test_ec_shortweierstrass_projective_g1_mul_vs_ref_" & $BN254_Snarks
# )

run_EC_mul_vs_ref_impl(
ec = EC_ShortW_Prj[Fp[BLS12_381], G1],
Expand Down
Loading