Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: drop old nim compiler versions #486

Merged
merged 1 commit into from
Nov 28, 2024
Merged

CI: drop old nim compiler versions #486

merged 1 commit into from
Nov 28, 2024

Conversation

mratsim
Copy link
Owner

@mratsim mratsim commented Nov 27, 2024

We remove explicit support for Nim 1.6.x as its EOL and Nim 2.0.x as one version to the next works or does not work.

Furthermore neither 1.6.12 or 2.0.12 can compile #485

Closes #471

@mratsim mratsim enabled auto-merge (squash) November 27, 2024 23:23
@mratsim mratsim disabled auto-merge November 28, 2024 06:01
@mratsim mratsim merged commit 2d67670 into master Nov 28, 2024
12 checks passed
@mratsim mratsim deleted the drop-old-nim-versions branch November 28, 2024 06:01
@tersec
Copy link

tersec commented Dec 7, 2024

Minimal reproducer for this in Nim 2.0 series:

template y(_: static int): untyped = int
type S[F: static int] = y(F)
type E[C: static int] = S[C]
discard sizeof(E[0])

@narimiran
Copy link

FWIW, a workaround is to change y(F) to y F or F.y.

@mratsim, would you be interested in making those changes to make constantine compatible with Nim 2.0.x again?

@mratsim
Copy link
Owner Author

mratsim commented Dec 13, 2024

Yes, but would they still work within a template? Because usually the dot syntax is broken within a template.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Compiler crash in nim/nightlies
3 participants