Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: improvements to loading project-local settings #290

Merged
merged 2 commits into from
Mar 17, 2024

Conversation

mrcjkb
Copy link
Owner

@mrcjkb mrcjkb commented Mar 15, 2024

@GuillaumeLagrange this implements support for loading settings from .vscode/settings.json.
You can test it with the vscode-settings-json branch.

I played around with workspace/didChangeConfiguration briefly, but couldn't get it to reload the configuration without behaving buggy.
If you come up with something that works, please let me know 😄

Note: Because the behaviour could be perceived as buggy, I have disabled it by default.
You can enable it with vim.g.rustaceanvim.server.load_vscode_settings = true

Copy link
Contributor

github-actions bot commented Mar 15, 2024

Review Checklist

Does this PR follow the Contribution Guidelines? Following is a partial checklist:

Proper conventional commit scoping:

  • For example, fix(lsp): some lsp-related bugfix

  • Pull request title has the appropriate conventional commit prefix.

If applicable:

  • Tested
    • Tests have been added.
    • Tested manually (Steps to reproduce in PR description).
  • Updated documentation.
  • Updated CHANGELOG.md

@mrcjkb mrcjkb force-pushed the vscode-settings-json branch from f9f6ea9 to 79b8f1a Compare March 15, 2024 02:23
@GuillaumeLagrange
Copy link
Contributor

@mrcjkb it works like a charm, thank you very much.

I'll look into dynamically reloading with workspaceDidChangeConfiguration and see if I can come up with anything, but as it is I can definitely ditch vs code again.
You might hear more from me regarding huge repo behavior in the future, thanks again !

@mrcjkb mrcjkb marked this pull request as draft March 15, 2024 12:59
@mrcjkb mrcjkb marked this pull request as ready for review March 17, 2024 11:34
@mrcjkb mrcjkb merged commit bb06512 into master Mar 17, 2024
8 checks passed
@mrcjkb mrcjkb deleted the vscode-settings-json branch March 17, 2024 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

More flexibility in root_dir selection inside a workspace for large monorepo
2 participants