Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(lsp): auto-register blink.cmp client capabilities #616

Merged
merged 1 commit into from
Dec 15, 2024

Conversation

unlimitedsola
Copy link
Contributor

Closes #615

I'm fairly new to this, so please let me know if extending both capabilities on top of each other when both are available is really a good idea :)

Copy link
Contributor

Review Checklist

Does this PR follow the Contribution Guidelines? Following is a partial checklist:

Proper conventional commit scoping:

  • For example, fix(lsp): some lsp-related bugfix

  • Pull request title has the appropriate conventional commit prefix.

If applicable:

  • Tested
    • Tests have been added.
    • Tested manually (Steps to reproduce in PR description).
  • Updated documentation.

Copy link
Owner

@mrcjkb mrcjkb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

please let me know if extending both capabilities on top of each other when both are available is really a good idea :)

I think it ought to be fine. Using both plugins at the same time is probably not a good idea anyway.

@mrcjkb mrcjkb merged commit 056078b into mrcjkb:master Dec 15, 2024
6 checks passed
@mrcjkb mrcjkb changed the title feat(lsp): support blink.cmp feat(lsp): auto-register blink.cmp client capabilities Dec 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support blink.cmp LSP capabilities
2 participants