-
-
Notifications
You must be signed in to change notification settings - Fork 35.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GLTFLoader: Implement KHR_draco_mesh_compression #13194
Conversation
* Updated DRACOLoader * Changed to request attribute only by unique id * Added support for skinning * Added more sample models
8b925c8
to
7d95279
Compare
PR for the Draco extension has been merged. Here's a demo with drag-and-drop support for any glTF+Draco model: https://gltf-viewer-experimental.donmccurdy.com/. |
Should this be merged then? |
One more thing I want to do here is check all of the latest glTF+Draco sample models.. otherwise if there are no code comments, I think it is OK to merge. /cc @zellski in case you've come across any issues so far. |
@donmccurdy I did minimal testing, but what I did do worked fine! |
c8a09a1
to
ef9ffde
Compare
938ca04
to
ab8b634
Compare
Ok, fixed one last thing to ensure that Draco meshes referenced multiple times are only decoded once. Sample models are all loading fine. I think this is ready. 👍 |
Thanks! |
Sorry for the late reply after merging. (Finally I've completed tons of paperwork and I'm back to dev!)
Seems like draco decoders are duplicated in
I'm considering if it'd be good to move draco decoders to Or adding readme explaining that master files are in another repo in
In the doc, I feel we need some more explanation about
Adding a link to https://github.com/google/draco/blob/master/javascript/example/README.md to doc would be good. |
The Draco decoders for use with the glTF extension are locked to a particular version of the Draco bitstream, until/unless a future version of the extension bumps them. The ones in
That sounds like a good idea, yes.
That would be good to document, sure. I am planning to add a |
And, welcome back! 😃 |
Ah, that's the reason why Hm, I think we need readme in |
Updated via #13351 |
Supports use of Draco compression on geometry in a glTF asset. Specification. Demo.
I'm planning to include a dedicated example (
loaders / gltf / draco
) but haven't got that ready yet. This PR just includes the Draco extension as an option on several of the existing examples. Up for discussion whether we want to merge with with these, remove the examples and add them in a future PR, or wait for a nicer dedicated example.Thanks @fanzhanggoogle for support on this PR and the rest of the Draco team. 🙂
/cc @takahirox