Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GLTFExporter: Implement KHR_lights_punctual. #15519

Merged
merged 1 commit into from
Jan 23, 2019
Merged

GLTFExporter: Implement KHR_lights_punctual. #15519

merged 1 commit into from
Jan 23, 2019

Conversation

donmccurdy
Copy link
Collaborator

@donmccurdy donmccurdy commented Jan 3, 2019 •
edited
Loading

Allow export of point, spot, and directional lights to glTF. For best results, lights should have their target as a child with position 0, 0, -1, and be oriented to face in the desired direction — similar to what GLTFLoader generates.

@donmccurdy donmccurdy mentioned this pull request Jan 3, 2019
Closed
87 tasks
@mrdoob mrdoob added this to the r101 milestone Jan 3, 2019
@mrdoob mrdoob requested a review from fernandojsg January 3, 2019 22:58
fernandojsg
fernandojsg approved these changes Jan 21, 2019
View reviewed changes
Copy link
Collaborator

@fernandojsg fernandojsg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. I think it could be nice to add spot and point lights on the example for the sake of completeness :)

@mrdoob
Copy link
Owner

mrdoob commented Jan 23, 2019

I think it could be nice to add spot and point lights on the example for the sake of completeness :)

Agreed. We can do this in another PR though.

@mrdoob mrdoob merged commit d2ea94f into mrdoob:dev Jan 23, 2019
@mrdoob
Copy link
Owner

mrdoob commented Jan 23, 2019

Thanks!

@donmccurdy donmccurdy deleted the feat-gltfexporter-khr_lights_punctual branch January 23, 2019 16:48
@Mugen87 Mugen87 mentioned this pull request Jul 12, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fernandojsg fernandojsg fernandojsg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
r101
Development

Successfully merging this pull request may close these issues.
3 participants
@donmccurdy @mrdoob @fernandojsg