Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GLTFLoader: Reset spotlight default position. #15565

Merged
merged 1 commit into from
Jan 25, 2019
Merged

GLTFLoader: Reset spotlight default position. #15565

merged 1 commit into from
Jan 25, 2019

Conversation

donmccurdy
Copy link
Collaborator

Fixes an inconsistency shown in KhronosGroup/glTF-Sample-Models#210.

@cx20
Copy link
Contributor

cx20 commented Jan 12, 2019

@donmccurdy I tried the updated GLTFLoader with gltf-test.
The position of the spotlight seems to be correct, but the color seems to be too bright.

three.js + Lights.gltf result:
image

image

Is the usage wrong? I have lights and IBL off.

@donmccurdy
Copy link
Collaborator Author

donmccurdy commented Jan 14, 2019 •
edited
Loading

@cx20 have you set renderer.physicallyCorrectLights=true? That will be required for matching the glTF spec.

@cx20
Copy link
Contributor

cx20 commented Jan 14, 2019

@donmccurdy Thanks to your advice the problem of brightness has been resolved.

three.js + physicallyCorrectLights flag + Lights.gltf result:
image

image

@donmccurdy donmccurdy requested a review from takahirox January 19, 2019 20:51
takahirox
takahirox approved these changes Jan 25, 2019
View reviewed changes
Copy link
Collaborator

@takahirox takahirox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The comment makes sense. Looking good to me.

@mrdoob mrdoob added this to the r101 milestone Jan 25, 2019
@mrdoob mrdoob merged commit ed5d702 into mrdoob:dev Jan 25, 2019
@mrdoob
Copy link
Owner

mrdoob commented Jan 25, 2019

Thanks!

@donmccurdy donmccurdy deleted the bug-spotlight-position branch July 9, 2021 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@takahirox takahirox takahirox approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
r101
Development

Successfully merging this pull request may close these issues.
4 participants
@donmccurdy @cx20 @mrdoob @takahirox