Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BatchedMesh: Add deleteGeometry(). #29523

Merged
merged 2 commits into from
Sep 29, 2024
Merged

Conversation

gkjohnson
Copy link
Collaborator

Related issue: #29463

Description

Adds a "deleteGeometry" function to BatchedMesh that follows the same patterns as #29449 - so if a geometry is removed it's id is reused, simplifying the implementation of future "optimize" function since ids won't have to be remapped.

cc @JordanLane-Veerum

@gkjohnson gkjohnson added this to the r170 milestone Sep 28, 2024
Copy link

📦 Bundle size

Full ESM build, minified and gzipped.

Before After Diff
WebGL 687.15
170.18
687.47
170.27
+319 B
+84 B
WebGPU 805.82
216.97
806.14
217.06
+319 B
+92 B
WebGPU Nodes 805.33
216.83
805.64
216.92
+319 B
+91 B

🌳 Bundle size after tree-shaking

Minimal build including a renderer, camera, empty scene, and dependencies.

Before After Diff
WebGL 462.85
111.79
462.85
111.79
+0 B
+0 B
WebGPU 535.59
144.55
535.59
144.55
+0 B
+0 B
WebGPU Nodes 491.75
134.31
491.75
134.31
+0 B
+0 B

@gkjohnson gkjohnson merged commit ccfcc1e into mrdoob:dev Sep 29, 2024
12 checks passed
@gkjohnson gkjohnson deleted the batch-delete-geom branch September 29, 2024 19:10
@Mugen87 Mugen87 changed the title BatchedMesh: Add deleteGeometry function BatchedMesh: Add deleteGeometry(). Sep 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants