Node: Document more modules. #30012
Merged
Node: Document more modules. #30012
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mugen87
commented
Dec 2, 2024
| @@ -937,22 +1111,25 @@ class NodeBuilder { | |||
|
|
|||
| } | |||
|
|
|||
| getStructTypeFromNode( node, shaderStage = this.shaderStage ) { | |||
| getStructTypeFromNode( node, types, shaderStage = this.shaderStage ) { | |||
There was a problem hiding this comment.
@sunag I have slightly refactored getStructTypeFromNode() so it is more similar to getBufferAttributeFromNode() or getUniformFromNode().
📦 Bundle sizeFull ESM build, minified and gzipped.
🌳 Bundle size after tree-shakingMinimal build including a renderer, camera, empty scene, and dependencies.
|
Mugen87
commented
Dec 2, 2024
| * | ||
| * @param {String} type - The input type. | ||
| * @param {String} name - The input name. | ||
| * @param {Number?} [count=null] - TODO (only relevant for GLSL). |
There was a problem hiding this comment.
@sunag Not sure about the purpose of count.
It also seems this part of the code throws currently a runtime error in GLSLNodeFunction. Try webgpu_materials with a WebGL backend.
Uncaught TypeError: undefined has no properties
parse$1 https://threejs.org/build/three.webgpu.js:27563
GLSLNodeFunction https://threejs.org/build/three.webgpu.js:27607
parseFunction https://threejs.org/build/three.webgpu.js:27655
This was referenced Dec 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue: #29984
Description
More API documentation.