Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PropertyBinding: Fix versioning scheme determination. #30054

Merged
merged 1 commit into from
Dec 7, 2024

Conversation

Mugen87
Copy link
Collaborator

@Mugen87 Mugen87 commented Dec 7, 2024

Fixed #30035.

Description

The PR makes sure PropertyBinding uses the is* flags for type detection. The previous approach of using update flags is error prone since such property might only exist as a setter.

@Mugen87 Mugen87 added this to the r172 milestone Dec 7, 2024
Copy link

github-actions bot commented Dec 7, 2024

📦 Bundle size

Full ESM build, minified and gzipped.

Before After Diff
WebGL 339.11
78.98
339.11
78.98
+0 B
+0 B
WebGPU 484.85
134.59
484.85
134.59
+0 B
+0 B
WebGPU Nodes 484.31
134.5
484.31
134.5
+0 B
+0 B

🌳 Bundle size after tree-shaking

Minimal build including a renderer, camera, empty scene, and dependencies.

Before After Diff
WebGL 465
112.04
465
112.04
+0 B
+0 B
WebGPU 554.24
150.04
554.24
150.04
+0 B
+0 B
WebGPU Nodes 510.12
139.75
510.12
139.75
+0 B
+0 B

@Mugen87 Mugen87 merged commit c3a82ac into mrdoob:dev Dec 7, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PropertyBinding on .material.color doesn't set needsUpdate
1 participant