Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nodes: fix type errors #30079

Merged
merged 1 commit into from
Dec 9, 2024
Merged

Nodes: fix type errors #30079

merged 1 commit into from
Dec 9, 2024

Conversation

s-rigaud
Copy link
Contributor

@s-rigaud s-rigaud commented Dec 9, 2024

Description

I tried running Typescript to check the coherence of all the types inside the nodes folder. I found some updates to improve the existing code and fix some TS warning:

  • Better typing for WeakMap
  • TempNode constructor name is not set from existing children like AssignNode or SetNode so I set the name as optional
  • String.charCodeAt requires an argument
  • Other small fixes

Copy link

github-actions bot commented Dec 9, 2024

📦 Bundle size

Full ESM build, minified and gzipped.

Before After Diff
WebGL 339.2
79.01
339.2
79.01
+0 B
+0 B
WebGPU 485.98
134.92
485.98
134.91
+6 B
-5 B
WebGPU Nodes 485.44
134.82
485.45
134.81
+6 B
-3 B

🌳 Bundle size after tree-shaking

Minimal build including a renderer, camera, empty scene, and dependencies.

Before After Diff
WebGL 465.1
112.06
465.1
112.06
+0 B
+0 B
WebGPU 555.38
150.4
555.38
150.39
+6 B
-5 B
WebGPU Nodes 511.23
140.1
511.24
140.09
+6 B
-4 B

@sunag sunag added this to the r172 milestone Dec 9, 2024
@sunag sunag merged commit 915b1d6 into mrdoob:dev Dec 9, 2024
12 checks passed
@s-rigaud s-rigaud deleted the types-fix-small-mistakes branch December 11, 2024 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants