New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Node: fix types #30102

Closed

s-rigaud wants to merge 1 commit into mrdoob:dev from s-rigaud:eslint-fix-types

Contributor

s-rigaud commented Dec 11, 2024

Description

Fix some typos and improve typings for some attributes.


          Node: fix types

3c1fb02

s-rigaud closed this

s-rigaud deleted the eslint-fix-types branch

December 11, 2024 14:24

github-actions bot commented Dec 11, 2024

📦 Bundle size

Full ESM build, minified and gzipped.

	Before	After	Diff
WebGL	339.21 79.01	339.21 79.01	+0 B +0 B
WebGPU	485.91 134.87	485.91 134.87	+0 B +0 B
WebGPU Nodes	485.38 134.77	485.38 134.77	+0 B +0 B

🌳 Bundle size after tree-shaking

Minimal build including a renderer, camera, empty scene, and dependencies.

	Before	After	Diff
WebGL	465.1 112.06	465.1 112.06	+0 B +0 B
WebGPU	555.02 150.3	555.02 150.3	+0 B +0 B
WebGPU Nodes	510.87 140.01	510.87 140.01	+0 B +0 B

s-rigaud restored the eslint-fix-types branch

December 11, 2024 14:29

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet