Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typos #30119

Merged
merged 1 commit into from
Dec 16, 2024
Merged

Typos #30119

merged 1 commit into from
Dec 16, 2024

Conversation

s-rigaud
Copy link
Contributor

Description

I used cSpell to clear the project of most (all ? 🤞) typos.

Sorry for the long read, I hope this is the final PR in an effort to clean all typos.

Copy link

github-actions bot commented Dec 13, 2024

📦 Bundle size

Full ESM build, minified and gzipped.

Before After Diff
WebGL 339.24
79.02
339.21
79.01
-30 B
-9 B
WebGPU 486.17
134.89
486.17
134.89
+0 B
+0 B
WebGPU Nodes 485.63
134.79
485.63
134.79
+0 B
+0 B

🌳 Bundle size after tree-shaking

Minimal build including a renderer, camera, empty scene, and dependencies.

Before After Diff
WebGL 465.13
112.08
465.1
112.07
-30 B
-8 B
WebGPU 555.32
150.32
555.32
150.32
+0 B
+0 B
WebGPU Nodes 511.24
140.09
511.24
140.09
+0 B
+0 B

@Mugen87
Copy link
Collaborator

Mugen87 commented Dec 13, 2024

Is it possible to only split the PR so this one only fixes typos in comments?

Right now, it also renames variables and that needs a closer test.

@s-rigaud
Copy link
Contributor Author

Done ✔️

@Mugen87 Mugen87 merged commit 53711ab into mrdoob:dev Dec 16, 2024
12 checks passed
@Mugen87 Mugen87 added this to the r172 milestone Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants