Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Node: Document more modules. #30142

Merged
merged 2 commits into from
Dec 17, 2024
Merged

Node: Document more modules. #30142

merged 2 commits into from
Dec 17, 2024

Conversation

Mugen87
Copy link
Collaborator

@Mugen87 Mugen87 commented Dec 17, 2024

Related issue: #29984

Description

Documents more node modules.

@Mugen87 Mugen87 added this to the r172 milestone Dec 17, 2024
Copy link

github-actions bot commented Dec 17, 2024

📦 Bundle size

Full ESM build, minified and gzipped.

Before After Diff
WebGL 339.21
79.01
339.21
79.01
+0 B
+0 B
WebGPU 486.36
134.94
486.36
134.94
+0 B
+0 B
WebGPU Nodes 485.83
134.84
485.83
134.84
+0 B
+0 B

🌳 Bundle size after tree-shaking

Minimal build including a renderer, camera, empty scene, and dependencies.

Before After Diff
WebGL 465.1
112.07
465.1
112.07
+0 B
+0 B
WebGPU 555.49
150.38
555.49
150.38
+0 B
+0 B
WebGPU Nodes 511.4
140.12
511.4
140.12
+0 B
+0 B

* ```
*
* @augments Node
*/
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have added this minimal code example for ScriptableNode so it's easier to figure out how to use the module.

That said, a separate guide or tutorial would be the better place to explain the concepts in more detail. It's a real interesting class!

@sunag sunag merged commit 42795bf into mrdoob:dev Dec 17, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants