Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TSL: More consistent names shadowPositionWorld, materialAO #30152

Merged
merged 3 commits into from
Dec 18, 2024

Conversation

sunag
Copy link
Collaborator

@sunag sunag commented Dec 17, 2024

Description

Keeps names more consistent with other nodes.

@sunag sunag changed the title TSL: More consistent names: shadowPositionWorld, materialAO TSL: More consistent names shadowPositionWorld, materialAO Dec 17, 2024
@sunag sunag added this to the r172 milestone Dec 17, 2024
Copy link

📦 Bundle size

Full ESM build, minified and gzipped.

Before After Diff
WebGL 339.21
79.01
339.21
79.01
+0 B
+0 B
WebGPU 486.55
134.98
486.54
134.97
-15 B
-9 B
WebGPU Nodes 486.02
134.88
486
134.88
-15 B
-8 B

🌳 Bundle size after tree-shaking

Minimal build including a renderer, camera, empty scene, and dependencies.

Before After Diff
WebGL 465.1
112.07
465.1
112.07
+0 B
+0 B
WebGPU 555.67
150.42
555.66
150.41
-12 B
-4 B
WebGPU Nodes 511.57
140.14
511.56
140.14
-12 B
-3 B

@RenaudRohlinger
Copy link
Collaborator

Actually shouldn't shadowPositionWorld be shadowPositionView? Only being able to update the world position seems restrictive.

@sunag
Copy link
Collaborator Author

sunag commented Dec 18, 2024

Actually shouldn't shadowPositionWorld be shadowPositionView? Only being able to update the world position seems restrictive.

The projection should be in world space, but maybe you have another idea? Maybe you could formulate it in a PR for us to analyze?

@sunag sunag marked this pull request as ready for review December 18, 2024 02:43
@sunag sunag merged commit 74b7a6f into mrdoob:dev Dec 18, 2024
12 checks passed
@sunag sunag deleted the dev-mat-names branch December 18, 2024 22:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants