Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Nodes - Document AtomicFunctionNode and BarrierNode #30153

Merged
merged 5 commits into from
Dec 18, 2024
Merged

Nodes - Document AtomicFunctionNode and BarrierNode #30153

merged 5 commits into from
Dec 18, 2024
+64 −54

Conversation

cmhhelgeson
Copy link
Contributor

@cmhhelgeson cmhhelgeson commented Dec 18, 2024 •
edited
Loading

Related issue: #XXXX

Description

Document AtomicFunctionNode and BarrierNode in src/nodes/gpu.

@cmhhelgeson cmhhelgeson changed the title Nodes - Document GPU Nodes Nodes - Document GPGPU Nodes Dec 18, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 18, 2024 •
edited
Loading

📦 Bundle size

Full ESM build, minified and gzipped.

Before After Diff
WebGL 339.4
79.05		 339.4
79.05		 +0 B
+0 B
WebGPU 486.55
134.98		 486.55
134.98		 +0 B
+0 B
WebGPU Nodes 486.02
134.88		 486.02
134.88		 +0 B
+0 B

🌳 Bundle size after tree-shaking

Minimal build including a renderer, camera, empty scene, and dependencies.

Before After Diff
WebGL 465.3
112.11		 465.3
112.11		 +0 B
+0 B
WebGPU 555.67
150.42		 555.67
150.42		 +0 B
+0 B
WebGPU Nodes 511.57
140.14		 511.57
140.14		 +0 B
+0 B

@cmhhelgeson cmhhelgeson changed the title Nodes - Document GPGPU Nodes Nodes - Document AtomicFunctionNode and BarrierNode Dec 18, 2024
@cmhhelgeson cmhhelgeson marked this pull request as ready for review December 18, 2024 04:54
@Mugen87 Mugen87 added this to the r172 milestone Dec 18, 2024
@Mugen87 Mugen87 merged commit 3c42174 into mrdoob:dev Dec 18, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mugen87 Mugen87 Mugen87 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
r172
Development

Successfully merging this pull request may close these issues.
2 participants
@cmhhelgeson @Mugen87