SkinningNode: Fix previousBoneMatrices
#30161
Merged
+10
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
📦 Bundle sizeFull ESM build, minified and gzipped.
🌳 Bundle size after tree-shakingMinimal build including a renderer, camera, empty scene, and dependencies.
|
mrdoob
reviewed
Dec 19, 2024
| if ( useVelocity ) { | ||
|
|
||
| object.userData = object.userData || {}; | ||
| object.userData.useVelocity = true; |
There was a problem hiding this comment.
May be better to do a local WeakMap for this?
I think we should avoid leaking renderer internals into userData.
There was a problem hiding this comment.
Oh, I can see that it's being accessed from another class...
Maybe better to call it _useVelocity then?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue: #29991
Description
Fix
webgpu_postprocessing_motion_blurafter ignore MRT in shadow rendering.