-
-
Notifications
You must be signed in to change notification settings - Fork 35.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Nodes: Document more modules. #30163
Conversation
this.isLineBasicNodeMaterial = true; | ||
|
||
this.lights = false; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have removed these statements since the default of lights
is already false
.
this.lights = false; | ||
this.transparent = true; | ||
|
||
this.sizeNode = null; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have removed this property since I think it's from a time where InstancedPointsNodeMaterial
was not available yet and we assumed we have to implement size support in PointsNodeMaterial
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was doing a review on InstancedPointsNodeMaterial
, with Nodes we wouldn't need variations for all this kind of case, and once we have Raycaster and BoundBox through GPU we will have an optimized support for procerural things. I'll try to show something in the next few weeks.
📦 Bundle sizeFull ESM build, minified and gzipped.
🌳 Bundle size after tree-shakingMinimal build including a renderer, camera, empty scene, and dependencies.
|
this.isPointsNodeMaterial = true; | ||
|
||
this.lights = false; | ||
this.transparent = true; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't remember, but removing it seems correct in the current context for me.
Related issue: #29984
Description
Documenting more node material classes.