Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nodes: Document more modules. #30163

Merged
merged 2 commits into from
Dec 18, 2024
Merged

Nodes: Document more modules. #30163

merged 2 commits into from
Dec 18, 2024

Conversation

Mugen87
Copy link
Collaborator

@Mugen87 Mugen87 commented Dec 18, 2024

Related issue: #29984

Description

Documenting more node material classes.

this.isLineBasicNodeMaterial = true;

this.lights = false;
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have removed these statements since the default of lights is already false.

this.lights = false;
this.transparent = true;

this.sizeNode = null;
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have removed this property since I think it's from a time where InstancedPointsNodeMaterial was not available yet and we assumed we have to implement size support in PointsNodeMaterial.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was doing a review on InstancedPointsNodeMaterial, with Nodes we wouldn't need variations for all this kind of case, and once we have Raycaster and BoundBox through GPU we will have an optimized support for procerural things. I'll try to show something in the next few weeks.

Copy link

📦 Bundle size

Full ESM build, minified and gzipped.

Before After Diff
WebGL 339.4
79.05
339.4
79.05
+0 B
+0 B
WebGPU 486.51
134.96
486.34
134.92
-178 B
-40 B
WebGPU Nodes 485.98
134.87
485.8
134.83
-178 B
-39 B

🌳 Bundle size after tree-shaking

Minimal build including a renderer, camera, empty scene, and dependencies.

Before After Diff
WebGL 465.3
112.11
465.3
112.11
+0 B
+0 B
WebGPU 555.65
150.41
555.47
150.37
-178 B
-33 B
WebGPU Nodes 511.54
140.14
511.54
140.14
+0 B
+0 B

this.isPointsNodeMaterial = true;

this.lights = false;
this.transparent = true;
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sunag You have added this line in #23600 although points are by default opaque according to PointsMaterial. Do you recall why you have added this?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't remember, but removing it seems correct in the current context for me.

@Mugen87 Mugen87 added this to the r172 milestone Dec 18, 2024
@Mugen87 Mugen87 merged commit fd53a1f into mrdoob:dev Dec 18, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants