[WIP] Add CubeTexture blur #30165
[WIP] Add CubeTexture blur #30165
Conversation
📦 Bundle sizeFull ESM build, minified and gzipped.
🌳 Bundle size after tree-shakingMinimal build including a renderer, camera, empty scene, and dependencies.
|
| const cubeUVsampler=Fn((envMap, sampleDirection)=>{ | ||
| return bilinearCubeUV( envMap, sampleDirection, mipInt, CUBEUV_TEXEL_WIDTH, CUBEUV_TEXEL_HEIGHT, CUBEUV_MAX_MIP ); | ||
| }); | ||
| material.fragmentNode = blur( { ...materialUniforms, latitudinal: latitudinal.equal( 1 ), sampler: cubeUVsampler } ); |
There was a problem hiding this comment.
This is the heart of the refactor I'm attempting - make the sampling function something that can be passed in so I can use different ones for a CubeUV texture vs an actual CubeTexture.
| @@ -214,7 +214,7 @@ export const textureCubeUV = /*@__PURE__*/ Fn( ( [ envMap, sampleDir_immutable, | |||
|
|
|||
| } ); | |||
|
|
|||
| const bilinearCubeUV = /*@__PURE__*/ Fn( ( [ envMap, direction_immutable, mipInt_immutable, CUBEUV_TEXEL_WIDTH, CUBEUV_TEXEL_HEIGHT, CUBEUV_MAX_MIP ] ) => { | |||
| export const bilinearCubeUV = /*@__PURE__*/ Fn( ( [ envMap, direction_immutable, mipInt_immutable, CUBEUV_TEXEL_WIDTH, CUBEUV_TEXEL_HEIGHT, CUBEUV_MAX_MIP ] ) => { | |||
There was a problem hiding this comment.
The error I'm getting is here: only the first two arguments are defined, so it crashes when it tries to read mipInt_immutable. My other comment shows where this is being called. I thought I had verified this kind of functional programming works in your TSL editor, but maybe something is subtly different? Am I hitting a real limitation of TSL here, or am I just doing something stupid? Any guidance @sunag?
There was a problem hiding this comment.
It seems to be related to the first argument of TSL function, I think that if you change of ( envMap, sampleDirection ) => to ( [ envMap, sampleDirection ] ) => it will work.
The second parameter in JS function is reserved for builder, where you can access the related material, object and geometry. For example: ( [ envMap, sampleDirection ], builder ) =>.
It is also possible to pass parameters as objects for example: ( { envMap, sampleDirection } ) => and call using bilinearCubeUV( { envMap, sampleDirection } ), can be useful for functions with many parameters.
I can help with whatever you need :) |
The idea here is to make the PMREM cubemap blur function available as a generic public blur method for a
CubeTexture. So far I only have a sketch, but this being my first attempt at using TSL, I've run into some early problems that I'd like to ask @sunag about.