Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sea3d revision 3 - optimized #7096

Merged
merged 3 commits into from
Sep 3, 2015
Merged

sea3d revision 3 - optimized #7096

merged 3 commits into from
Sep 3, 2015

Conversation

sunag
Copy link
Collaborator

@sunag sunag commented Sep 3, 2015

Hi. I made a version of SEA3D optimized for the Three.JS improving the performance all in THREE.BufferGeometry r72 and some new features.

http://community.poonya.com/160

Fixes #6914

Cheers.


// SEA3D

this.file.typeRead[ SEA3D.Geometry.prototype.type ] =
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you're missing the other side of the equality here?

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah wait. You are assigning the result from the next line 😮

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this safe? See the other comment.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See point 2 of the answer to this so question

Not sure if it applies to this situation, and if it is still accurate info.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like I was wrong. This kind of assignment is valid (atleast in chrome)

jsfiddle

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

JavaScript compilers should turn into Tokens line break, tabs and traditional space in the same class.

Line 262: isWhitespace https://github.com/google/closure-compiler/blob/0c09d82ab71f5518d6334692d279615e59c2b455/src/com/google/javascript/jscomp/parsing/parser/Scanner.java

Other compilers like AS3 of Adobe by Jeff Dyer and other parser of AS3 by Victor Dramba use the same hierarchy.

mrdoob added a commit that referenced this pull request Sep 3, 2015
sea3d revision 3 - optimized
@mrdoob mrdoob merged commit cd3a147 into mrdoob:dev Sep 3, 2015
@mrdoob
Copy link
Owner

mrdoob commented Sep 3, 2015

Nice! Thanks!

@mrdoob
Copy link
Owner

mrdoob commented Sep 3, 2015

You should remove the call to computeTangets() btw, just removed it.

@mrdoob
Copy link
Owner

mrdoob commented Sep 23, 2015

@sunag could you update the loader so it uses the new animation system (#6934)?

@sunag
Copy link
Collaborator Author

sunag commented Sep 23, 2015

@mrdoob @bhouston All right! but it will take a while because of schedule this month. it is already possible to create additive layers in this system? would be for skeleton animation...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants