expose VR displays from THREE.VREffect/THREE.VRControls #9133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| function gotVRDevices( devices ) { | ||
| function gotVRDevices ( devices ) { | ||
|
|
||
| scope.displays = devices; |
There was a problem hiding this comment.
This is sneaky... I would, instead, define a local variable displays and add a .getDisplays() public method.
There was a problem hiding this comment.
Also, I guess .getDevices() would match the WebVR API better?
There was a problem hiding this comment.
I had that originally; can change, for sure. well, actually the v1.0 API calls for navigator.getVRDisplays() instead of navigator.getVRDevices(), so I'd suggest the former.
mrdoob
added a commit
that referenced
this pull request
Jun 30, 2016
mrdoob
added a commit
that referenced
this pull request
Jun 30, 2016
|
Ended up adding |
|
awesome, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.