fix ImageLoader manager issue #9176
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oh! Interesting... I think this is, in fact, a regression? 😐 |
|
Thanks! |
Closed
| @@ -26,7 +30,7 @@ Object.assign( THREE.ImageLoader.prototype, { | |||
|
|
|||
| } else { | |||
|
|
|||
| var loader = new THREE.XHRLoader( this.manager ); | |||
There was a problem hiding this comment.
Why remove this.manager? In #9600 I put it back.
There was a problem hiding this comment.
I think because it would produce duplicates otherwise.
There was a problem hiding this comment.
The ImageLoader will call the methods itemStart and itemEnd of its loadingManager and the XHRLoader/FileLoader will call the same methods of a default loading Manager. I think it would be nice to let the FileLoader use the loading manager and this way we can store all active requests and abort them all.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The image won't complete until image.onload be called.