Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BVHLoader & example #9188

Merged
merged 6 commits into from
Jun 23, 2016
Merged

BVHLoader & example #9188

merged 6 commits into from
Jun 23, 2016

Conversation

herzig
Copy link
Contributor

@herzig herzig commented Jun 21, 2016

Loader for BVH files including a simple example.

Files with multiple ROOTs (i.e. multiple characters) are not supported, I haven't come across such files yet..

@herzig herzig changed the title Adds a BVH Loader & example #5524 BVHLoader & example Jun 21, 2016
@WestLangley
Copy link
Collaborator

http://threejsworker.com/api/pullrequests/9188/examples/webgl_loader_bvh.html

Thanks! You will need to include the example in examples/files.

@herzig
Copy link
Contributor Author

herzig commented Jun 21, 2016

@WestLangley Do you mean the bvh file? or the whole example?
Also, do I have to do something so that the example shows up in the example browser (like register it somewhere)?

var mesh;

var loader = new THREE.BVHLoader();
loader.load( "models/bvh/pirouette.bvh", ( result ) => {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

loader.load( "models/bvh/pirouette.bvh", ( result ) {

@WestLangley
Copy link
Collaborator

Add your new example to https://github.com/mrdoob/three.js/blob/dev/examples/files.js.

Your example is throwing errors -- perhaps because your mesh geometry has no faces. There likely is another way of handling this.

@herzig
Copy link
Contributor Author

herzig commented Jun 21, 2016

I think it should all be fine now,
thanks for your help.

@mrdoob
Copy link
Owner

mrdoob commented Jun 22, 2016

http://threejsworker.com/api/pullrequests/9188/examples/webgl_loader_bvh.html

The skeleton animates but stays in the same place. Is that correct?

@herzig
Copy link
Contributor Author

herzig commented Jun 22, 2016

Yes, this example bvh file does not contain any position channels. Should I replace it with another one?

@mrdoob
Copy link
Owner

mrdoob commented Jun 22, 2016

I think so yes, people may think it's broken otherwise...

@herzig
Copy link
Contributor Author

herzig commented Jun 22, 2016

You're right, I agree! Also added an attribution to the original source of the animation.

@mrdoob mrdoob merged commit c87ca5d into mrdoob:dev Jun 23, 2016
@mrdoob
Copy link
Owner

mrdoob commented Jun 23, 2016

Sweet! Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants