Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ConvexGeometry: use flat vertex normals #9221

Merged
merged 1 commit into from
Jun 24, 2016
Merged

ConvexGeometry: use flat vertex normals #9221

merged 1 commit into from
Jun 24, 2016

Conversation

WestLangley
Copy link
Collaborator

As discussed in #9220.

@WestLangley
Copy link
Collaborator Author

http://threejsworker.com/api/pullrequests/9221/examples/webgl_geometry_convex.html

What improvement does this example need?

@mrdoob
Copy link
Owner

mrdoob commented Jun 24, 2016

What improvement does this example need?

Hmmm, maybe it would be nice to see the points (using THREE.Points) superimposed to the resulting geometry.

@WestLangley
Copy link
Collaborator Author

OK. A single mesh would be sufficient?

@mrdoob
Copy link
Owner

mrdoob commented Jun 24, 2016

Yep! 😊

@mrdoob
Copy link
Owner

mrdoob commented Jun 24, 2016

Merging this one by now.

@mrdoob mrdoob merged commit a350f91 into mrdoob:dev Jun 24, 2016
@mrdoob
Copy link
Owner

mrdoob commented Jun 24, 2016

Thanks!

@WestLangley WestLangley deleted the dev-convex_flat branch June 24, 2016 21:16
@WestLangley WestLangley mentioned this pull request Jun 25, 2016
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@WestLangley @mrdoob