Skip to content

Commit

Permalink
[A11y] Reland targeted cached property invalidation
Browse files Browse the repository at this point in the history
Relands the following CLS:
* Enhance performance by targeting value updates to specific nodes, commit 704633e6846e44b20c488a3eb98fa43c2c8e4591.
* Don't queue anything for irrelevant attribute changes, commit 2c66a62ed62e601b7a81271e4be4f9e173ce9afc.
* Add comment explaining call to UpdateStyleAndLayoutTreeForNode(), commit 73b9eed3b48bc8ce70de657672755f44a89e7358.
* Ensure cached values not invalidated during the computation of them, commit 4d167a62cd13d5209ecefb664e3690ac955bc559.
* Run a test with --force-renderer-accessibility that used to fail, commit cab7ecd829b24acf677e02f8f118085eaad7f799.
* Simplify code to update cached focusable state, commit 79cb184e5dab5f6084ec78d485bd9496eaa0aaf8.
* Simplify code that invalidates cached values on an AXObject, commit 6df79a50a55fe5cf99d2c50f7308e1236361b771.

Fixed: 1446864, 1446550, 1434555, 1362758
Change-Id: I16855bdcb746cb41387b69e1e97ab72ffc47e342
Cq-Do-Not-Cancel-Tryjobs: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4545510
Commit-Queue: Aaron Leventhal <aleventhal@chromium.org>
Reviewed-by: Jacques Newman <janewman@microsoft.com>
Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Reviewed-by: Philip Rogers <pdr@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1157878}
  • Loading branch information
aleventhal authored and chromium-wpt-export-bot committed Jun 15, 2023
1 parent 5b990f3 commit 777cb34
Showing 1 changed file with 23 additions and 0 deletions.
23 changes: 23 additions & 0 deletions accessibility/crashtests/add-detached-node.html
Original file line number Diff line number Diff line change
@@ -0,0 +1,23 @@
<!DOCTYPE html>
<html class="test-wait">
<body onload="start()">
<script>
function start() {
requestAnimationFrame(() => {
target2.placeholder = "string";
target1.type = "hidden";
document.documentElement.className = '';
});
}
</script>

<ol id=target1 inert>
<content>
<textarea id=target2></textarea>
<semantics>
<optgroup></optgroup>
</semantics>
</content>
</ol>
</body>
</html>

0 comments on commit 777cb34

Please sign in to comment.