Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: renaming property does not remove old property #157

Merged
merged 1 commit into from
Oct 5, 2023

Conversation

mrgrain
Copy link
Owner

@mrgrain mrgrain commented Oct 5, 2023

The following pseud-code would incorrectly result in a struct containing newProp and oldProp.

  struct.add({ name: 'oldProp' });
  struct.rename('oldProp', 'newProp');

@mergify mergify bot merged commit 2c84763 into main Oct 5, 2023
9 checks passed
@mergify mergify bot deleted the mrgrain/fix/rename-not-delete-old-prop branch October 5, 2023 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant