Use the same filename conversion when loading and saving files. #135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MyFrame::LoadPuzzle uses wx2file to convert wxString filenames to std::string filenames suitable for use with native C++ APIs, but MyFrame::DoSavePuzzle was using puz::encode_utf8(wx2puz(...)) which appears to mangle accents on Windows. Use wx2file everywhere. Also make line endings consistent so VS stops complaining.
|
(Only tested on Windows at the moment, but doesn't seem like it should cause issues on Mac given that loading works fine there. LMK if you need me to check on Mac as well). |
|
Works for me 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MyFrame::LoadPuzzle uses wx2file to convert wxString filenames to
std::string filenames suitable for use with native C++ APIs, but
MyFrame::DoSavePuzzle was using puz::encode_utf8(wx2puz(...)) which
appears to mangle accents on Windows. Use wx2file everywhere.
Also make line endings consistent so VS stops complaining.
Fixes #133