Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix crash on latest MacOS version. #150

Merged
merged 1 commit into from
Jul 8, 2021
Merged

Conversation

jpd236
Copy link
Contributor

@jpd236 jpd236 commented Jun 6, 2021

- Update wxWidgets to 3.1.5 to fix https://trac.wxwidgets.org/ticket/19100
- wxWidgets 3.1.5 drops support for MacOS < 10.10, so bump to that minimum
- Remove obsolete wxWidgets patch
@jpd236
Copy link
Contributor Author

jpd236 commented Jun 6, 2021

Gave this a cursory test on Windows and Mac and it seems to at least be basically functional, though there may be trickier bugs under the covers.

The Mac UI is a bit different now, particularly with the toolbar. It looks off to me - I think the icons are probably 2x the size they're supposed to be, and it's odd that they're level with the window title now as opposed to below it, but I'm guessing this is meant to match newer Mac style better?

@mrichards42
Copy link
Owner

Will take a look at this in combination with my wxlua3 branch. My attempts at this without upgrading wxLua all failed with

./lua/wxbind/src/wxcore_event.cpp:2808:33: error: no matching constructor for initialization of 'wxPaintEvent'
    wxPaintEvent* returns = new wxPaintEvent(id);

@jpd236
Copy link
Contributor Author

jpd236 commented Jun 7, 2021

Yep, this PR is against the wxlua3 branch rather than the master branch for the same reason.

@mrichards42
Copy link
Owner

So it is :)

@mrichards42 mrichards42 merged commit 41f16fb into mrichards42:wxlua3 Jul 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants