Use transparent background in HTML windows #159
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The HTML background is per cell, and a solid color background (even white) can potentially draw on top of neighbor cells. This can appear, e.g. with the rightmost character of italic text getting cut off. The solution is to use wxHTML_CLR_TRANSPARENT_BACKGROUND as the initial/default background, which results in dc.SetBackgroundMode(wxBRUSHSTYLE_TRANSPARENT). Using just wxHTML_CLR_BACKGROUND results in wxBRUSHSTYLE_SOLID. This is essentially the same as http://trac.wxwidgets.org/ticket/14986, but since we don't have a `<body>` tag, we have to add the transparent background color cell ourselves.
mrichards42
force-pushed
the
html-italics
branch
from
6e00ac4 to
107528e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The control itself draws the background. The HTML background is per
cell, and a solid color background (even white) can potentially draw on
top of neighbor cells. This can appear, e.g. with the rightmost
character of italic text getting cut off.
Fixes #158