Merge pull request #342 from Trott/cliff

fix: remove performance cliff for regex
mrmlnc · Jan 4, 2022 · 3325450 · 3325450
2 parents 95838d1 + fe57c2b
commit 3325450
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 1 deletion.
diff --git a/src/utils/pattern.spec.ts b/src/utils/pattern.spec.ts
@@ -118,6 +118,8 @@ describe('Utils → Pattern', () => {
 
 			it('should return false for unfinished regex group', () => {
 				assert.ok(!util.isDynamicPattern('(a|b'));
+				assert.ok(!util.isDynamicPattern('('.repeat(999999) + 'a|b'));
+				assert.ok(!util.isDynamicPattern('(a' + '|'.repeat(999999) + 'b'));
 				assert.ok(!util.isDynamicPattern('abc/(a|b'));
 			});
 

diff --git a/src/utils/pattern.ts b/src/utils/pattern.ts
@@ -10,7 +10,7 @@ const ESCAPE_SYMBOL = '\\';
 
 const COMMON_GLOB_SYMBOLS_RE = /[*?]|^!/;
 const REGEX_CHARACTER_CLASS_SYMBOLS_RE = /\[[^[]*]/;
-const REGEX_GROUP_SYMBOLS_RE = /(?:^|[^!*+?@])\(.*\|.*\)/;
+const REGEX_GROUP_SYMBOLS_RE = /(?:^|[^!*+?@])\([^(]*\|[^|]*\)/;
 const GLOB_EXTENSION_SYMBOLS_RE = /[!*+?@]\(.*\)/;
 const BRACE_EXPANSIONS_SYMBOLS_RE = /{.*(?:,|\.\.).*}/;