Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement glob.hasMagic #105

Closed
alexander-akait opened this issue May 9, 2018 · 6 comments
Closed

Implement glob.hasMagic #105

alexander-akait opened this issue May 9, 2018 · 6 comments
Assignees
Milestone

Comments

@alexander-akait
Copy link

Environment

  • OS Version: no matter
  • Node.js Version: no matter

Actual behavior

Doesn't have hasMagic function.

Expected behavior

Has hasMagic function. With same logic from https://github.com/isaacs/node-glob#globhasmagicpattern-options. Why? Allow full migrate from node-glob to fast-glob

Steps to reproduce

not required

Code sample

not required

Thanks!

@sindresorhus
Copy link

Would be useful if you could support multiple patterns here, in contrast to node-glob, so we can just depend on your implementation in globby.

@alexander-akait
Copy link
Author

/cc @mrmlnc friendly ping

@mrmlnc
Copy link
Owner

mrmlnc commented Jul 4, 2018

@evilebottnawi,

Right now, I'm working on a different functionality that allows me to reduce the File System time by 10-20%.

I will come back to this issue later (in the next week, as I think).

@mrmlnc mrmlnc added this to the 3.0.0 milestone Jan 2, 2019
@mrmlnc mrmlnc modified the milestones: 3.0.0, 2.3.0 Feb 20, 2019
@Qix-
Copy link

Qix- commented Apr 2, 2019

@mrmlnc It's been a few weeks... 🙃 ping?

@mrmlnc
Copy link
Owner

mrmlnc commented Apr 2, 2019

Sorry, I moved this issue to the milestones 3.0.0. Right now I work on performance issues.

@mrmlnc
Copy link
Owner

mrmlnc commented Sep 29, 2019

Will be available with fast-glob@3.1.0 (#231).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants