ISSUE-105: Introduce the isDynamicPattern method (alternative for hasMagic)
#230
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrmlnc
force-pushed
the
ISSUE-105_glob_has_magic
branch
from
3d012db
to
38b8388
Compare
mrmlnc
changed the title
isDynamicPattern method (alternative for hasMagicisDynamicPattern method (alternative for hasMagic)
mrmlnc
force-pushed
the
ISSUE-105_glob_has_magic
branch
3 times, most recently
from
bf0bd3b
to
6a09a06
Compare
Our solution allows to use some options that affect the match. Most likely, after we understand that the solution works and works well, we will try to join this code with `is-glob` package.
mrmlnc
force-pushed
the
ISSUE-105_glob_has_magic
branch
from
6a09a06
to
cf9d91b
Compare
mrmlnc
commented
Sep 29, 2019
mrmlnc
force-pushed
the
ISSUE-105_glob_has_magic
branch
from
cf9d91b
to
2a07e44
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request?
This is the functionality that was requested in #105.
What changes did you make? (Give an overview)
Use our own solution instead of
is-globpackage (passess the original tests with some discression). Our solution allows you to use some options that affect the match. Most likely, after we understand that the solution works and works well, we will try to join this code withis-globpackage. I don't know now who uses struct syntax and why.