TRIVIAL: use ESLint instead of TSLint

.eslintrc.json

@@ -0,0 +1,3 @@
+{
+	"extends": "mrmlnc"
+}

.gitignore

@@ -11,6 +11,7 @@ npm-debug.log*
 node_modules/
 
 # Compiled and temporary files
+.eslintcache
 .tmp/
 .benchmark/
 out/

.npmignore

@@ -4,9 +4,12 @@
 .gitignore
 .vsts
 tsconfig.json
-tslint.json
+.eslintrc.json
 
-# Builded files
+# Log & Cache files
+.eslintcache
+
+# Build files
 out/benchmark
 out/tests
 out/**/*.js.map

package.json

@@ -20,43 +20,42 @@
     "implementation"
   ],
   "devDependencies": {
-    "@nodelib/fs.macchiato": "^1.0.0",
+    "@nodelib/fs.macchiato": "^1.0.1",
     "@types/compute-stdev": "^1.0.0",
     "@types/easy-table": "^0.0.32",
-    "@types/execa": "^0.9.0",
     "@types/glob": "^7.1.1",
     "@types/glob-parent": "^5.1.0",
     "@types/merge2": "^1.1.4",
     "@types/micromatch": "^3.1.0",
     "@types/minimist": "^1.2.0",
     "@types/mocha": "^5.2.7",
-    "@types/node": "^12.0.10",
+    "@types/node": "^12.7.8",
     "@types/rimraf": "^2.0.2",
-    "@types/sinon": "^7.0.13",
+    "@types/sinon": "^7.5.0",
     "compute-stdev": "^1.0.0",
     "easy-table": "^1.1.1",
-    "execa": "^1.0.0",
-    "fast-glob": "^3.0.2",
+    "eslint": "^6.5.1",
+    "eslint-config-mrmlnc": "^1.0.1",
+    "execa": "^2.0.4",
+    "fast-glob": "^3.0.4",
     "glob": "^7.1.4",
     "minimist": "^1.2.0",
-    "mocha": "^6.1.4",
-    "rimraf": "^2.6.3",
-    "sinon": "^7.3.2",
+    "mocha": "^6.2.1",
+    "rimraf": "^3.0.0",
+    "sinon": "^7.5.0",
     "tiny-glob": "^0.2.6",
-    "tslint": "^5.18.0",
-    "tslint-config-mrmlnc": "^2.1.0",
-    "typescript": "^3.5.2"
+    "typescript": "^3.6.3"
   },
   "dependencies": {
-    "@nodelib/fs.stat": "^2.0.1",
-    "@nodelib/fs.walk": "^1.2.1",
+    "@nodelib/fs.stat": "^2.0.2",
+    "@nodelib/fs.walk": "^1.2.3",
     "glob-parent": "^5.1.0",
-    "merge2": "^1.2.3",
+    "merge2": "^1.3.0",
     "micromatch": "^4.0.2"
   },
   "scripts": {
     "clean": "rimraf out",
-    "lint": "tslint \"src/**/*.ts\" -p . -t stylish",
+    "lint": "eslint \"src/**/*.ts\" --cache",
     "compile": "tsc",
     "test": "mocha \"out/**/*.spec.js\" -s 0",
     "smoke": "mocha \"out/**/*.smoke.js\" -s 0",

src/benchmark/index.ts

@@ -1,25 +1,30 @@
-import minimist = require('minimist');
+import * as minimist from 'minimist';
 
 import * as logger from './logger';
 import Runner, { RunnerOptions } from './runner';
 import * as utils from './utils';
 
-interface Arguments extends RunnerOptions {
+const PROCESS_FIRST_ARGUMENT_INDEX = 2;
+const DEFAULT_BENCHMARK_LAUNCHES = 10;
+const DEFAULT_BENCHMARK_MAX_STDEV = 3;
+const DEFAULT_BENCHMARK_RETRIES = 5;
+
+type Arguments = RunnerOptions & {
 	basedir: string;
-}
+};
 
 const defaultArgv: Arguments = {
 	basedir: '.',
-	type: process.env.BENCHMARK_TYPE || 'product',
-	mode: process.env.BENCHMARK_MODE || 'async',
-	pattern: process.env.BENCHMARK_PATTERN || '*',
-	launches: utils.getEnvAsInteger('BENCHMARK_LAUNCHES') || 10,
-	maxStdev: utils.getEnvAsInteger('BENCHMARK_MAX_STDEV') || 3,
-	retries: utils.getEnvAsInteger('BENCHMARK_RETRIES') || 5,
-	options: utils.getEnvAsObject('BENCHMARK_OPTIONS') || {}
+	type: utils.getEnvironmentAsString('BENCHMARK_TYPE', 'product'),
+	mode: utils.getEnvironmentAsString('BENCHMARK_MODE', 'async'),
+	pattern: utils.getEnvironmentAsString('BENCHMARK_PATTERN', '*'),
+	launches: utils.getEnvironmentAsInteger('BENCHMARK_LAUNCHES', DEFAULT_BENCHMARK_LAUNCHES),
+	maxStdev: utils.getEnvironmentAsInteger('BENCHMARK_MAX_STDEV', DEFAULT_BENCHMARK_MAX_STDEV),
+	retries: utils.getEnvironmentAsInteger('BENCHMARK_RETRIES', DEFAULT_BENCHMARK_RETRIES),
+	options: utils.getEnvironmentAsObject('BENCHMARK_OPTIONS', {})
 };
 
-const argv = minimist<Arguments>(process.argv.slice(2), {
+const argv = minimist<Arguments>(process.argv.slice(PROCESS_FIRST_ARGUMENT_INDEX), {
 	default: defaultArgv
 });
 

src/benchmark/reporter.ts

@@ -1,4 +1,6 @@
-import { SuitePackResult } from './runner';
+import { SuitePackResult, SuitePackMeasures } from './runner';
+
+const FRACTION_DIGITS = 3;
 
 export default class Reporter {
 	constructor(private readonly _results: SuitePackResult) { }
@@ -20,16 +22,18 @@ export default class Reporter {
 	}
 
 	private _formatMeasures(): string {
-		return Object.keys(this._results.measures).map(this._formatMeasure, this).join(' | ');
+		const keys = Object.keys(this._results.measures) as Array<keyof SuitePackMeasures>;
+
+		return keys.map(this._formatMeasure, this).join(' | ');
 	}
 
-	private _formatMeasure(name: string): string {
+	private _formatMeasure(name: keyof SuitePackMeasures): string {
 		const data = this._results.measures[name];
 
 		return [
 			'(' + name.toUpperCase() + ')',
-			this._formatValue(data.average, data.units, 3),
-			'±' + this._formatValue(data.stdev, '%', 3)
+			this._formatValue(data.average, data.units, FRACTION_DIGITS),
+			'±' + this._formatValue(data.stdev, '%', FRACTION_DIGITS)
 		].join(' ');
 	}
 

src/benchmark/runner.spec.ts

@@ -39,7 +39,7 @@ describe('Benchmark → Runner', () => {
 
 	describe('.suite', () => {
 		it('should returns measures', () => {
-			const runner = new RunnerFakeProcess('basedir', {} as RunnerOptions);
+			const runner = new RunnerFakeProcess('basedir', runnerOptions);
 
 			const expected: SuiteMeasures = {
 				matches: 1,
@@ -53,7 +53,7 @@ describe('Benchmark → Runner', () => {
 		});
 
 		it('should throw error', () => {
-			const runner = new RunnerFakeProcessError('basedir', {} as RunnerOptions);
+			const runner = new RunnerFakeProcessError('basedir', runnerOptions);
 
 			assert.throws(() => runner.suite('suitePath'), /Ops! Broken suite run\./);
 		});

src/benchmark/runner.ts

@@ -1,47 +1,47 @@
 import * as fs from 'fs';
 import * as path from 'path';
 
-import execa = require('execa');
-
 import { Options } from '../settings';
 import Reporter from './reporter';
 import * as utils from './utils';
 
-export interface RunnerOptions {
+import execa = require('execa'); // eslint-disable-line @typescript-eslint/no-require-imports
+
+export type RunnerOptions = {
 	type: string;
 	mode: string;
 	pattern: string;
 	launches: number;
 	maxStdev: number;
 	retries: number;
 	options: Options;
-}
+};
 
-export interface SuiteMeasures {
+export type SuiteMeasures = {
 	matches: number;
 	time: number;
 	memory: number;
-}
+};
 
-export interface Measure {
+export type Measure = {
 	units: string;
 	raw: number[];
 	average: number;
 	stdev: number;
-}
+};
 
-export interface SuitePackMeasures extends Record<string, Measure> {
+export type SuitePackMeasures = {
 	time: Measure;
 	memory: Measure;
-}
+};
 
-export interface SuitePackResult {
+export type SuitePackResult = {
 	name: string;
 	errors: number;
 	entries: number;
 	retries: number;
 	measures: SuitePackMeasures;
-}
+};
 
 export default class Runner {
 	constructor(private readonly _basedir: string, private readonly _options: RunnerOptions) { }
@@ -54,14 +54,17 @@ export default class Runner {
 	 * Runs a single suite in the child process and returns the measurements of his work.
 	 */
 	public suite(suitePath: string): SuiteMeasures {
-		const env: NodeJS.ProcessEnv = {
+		const environment: NodeJS.ProcessEnv = {
 			NODE_ENV: 'production',
 			BENCHMARK_BASE_DIR: this._basedir,
 			BENCHMARK_PATTERN: this._options.pattern,
 			BENCHMARK_OPTIONS: JSON.stringify(this._options.options)
 		};
 
-		const stdout = this.execNodeProcess([suitePath], { env, extendEnv: true });
+		// eslint-disable-next-line unicorn/prevent-abbreviations
+		const execaOptions: execa.SyncOptions = { env: environment, extendEnv: true };
+
+		const stdout = this.execNodeProcess([suitePath], execaOptions);
 
 		try {
 			return JSON.parse(stdout) as SuiteMeasures;

src/benchmark/suites/product/async/fast-glob.ts

@@ -1,6 +1,6 @@
 import * as path from 'path';
 
-import * as glob from '../../../../index';
+import * as glob from '../../../..';
 import * as utils from '../../../utils';
 
 const options: glob.Options = {
@@ -14,7 +14,7 @@ glob(process.env.BENCHMARK_PATTERN as string, options)
 	.then((matches) => {
 		const memory = utils.getMemory();
 		const time = utils.timeEnd(timeStart);
-		const measures = utils.getMeasures(matches.length, time, memory);
+		const measures = utils.formatMeasures(matches.length, time, memory);
 
 		console.info(measures);
 	})

src/benchmark/suites/product/async/node-glob.ts

@@ -1,6 +1,6 @@
 import * as path from 'path';
 
-import glob = require('glob');
+import * as glob from 'glob';
 
 import * as utils from '../../../utils';
 
@@ -14,13 +14,13 @@ const options: glob.IOptions = {
 const timeStart = utils.timeStart();
 
 glob(process.env.BENCHMARK_PATTERN as string, options, (error, matches) => {
-	if (error) {
+	if (error !== null) {
 		process.exit(0);
 	}
 
 	const memory = utils.getMemory();
 	const time = utils.timeEnd(timeStart);
-	const measures = utils.getMeasures(matches.length, time, memory);
+	const measures = utils.formatMeasures(matches.length, time, memory);
 
 	console.info(measures);
 });

src/benchmark/suites/product/async/tiny-glob.ts

@@ -1,9 +1,9 @@
 import * as path from 'path';
 
-import glob = require('tiny-glob');
-
 import * as utils from '../../../utils';
 
+import glob = require('tiny-glob'); // eslint-disable-line @typescript-eslint/no-require-imports
+
 const options = {
 	cwd: path.join(process.cwd(), process.env.BENCHMARK_BASE_DIR as string),
 	flush: true
@@ -15,7 +15,7 @@ glob(process.env.BENCHMARK_PATTERN as string, options)
 	.then((matches) => {
 		const memory = utils.getMemory();
 		const time = utils.timeEnd(timeStart);
-		const measures = utils.getMeasures(matches.length, time, memory);
+		const measures = utils.formatMeasures(matches.length, time, memory);
 
 		console.info(measures);
 	})

src/benchmark/suites/product/stream/fast-glob.ts

@@ -1,6 +1,6 @@
 import * as path from 'path';
 
-import * as glob from '../../../../index';
+import * as glob from '../../../..';
 import * as utils from '../../../utils';
 
 const options: glob.Options = {
@@ -20,7 +20,7 @@ stream.on('data', (entry: string) => entries.push(entry));
 stream.once('end', () => {
 	const memory = utils.getMemory();
 	const time = utils.timeEnd(timeStart);
-	const measures = utils.getMeasures(Array.from(entries).length, time, memory);
+	const measures = utils.formatMeasures(entries.length, time, memory);
 
 	console.info(measures);
 });

src/benchmark/suites/product/sync/fast-glob.ts

@@ -1,6 +1,6 @@
 import * as path from 'path';
 
-import * as glob from '../../../../index';
+import * as glob from '../../../..';
 import * as utils from '../../../utils';
 
 const options: glob.Options = {
@@ -14,7 +14,7 @@ try {
 	const matches = glob.sync(process.env.BENCHMARK_PATTERN as string, options);
 	const memory = utils.getMemory();
 	const time = utils.timeEnd(timeStart);
-	const measures = utils.getMeasures(matches.length, time, memory);
+	const measures = utils.formatMeasures(matches.length, time, memory);
 
 	console.info(measures);
 } catch {

src/benchmark/suites/product/sync/node-glob.ts

@@ -1,6 +1,6 @@
 import * as path from 'path';
 
-import glob = require('glob');
+import * as glob from 'glob';
 
 import * as utils from '../../../utils';
 
@@ -17,7 +17,7 @@ try {
 	const matches = glob.sync(process.env.BENCHMARK_PATTERN as string, options);
 	const memory = utils.getMemory();
 	const time = utils.timeEnd(timeStart);
-	const measures = utils.getMeasures(matches.length, time, memory);
+	const measures = utils.formatMeasures(matches.length, time, memory);
 
 	console.info(measures);
 } catch {

src/benchmark/suites/regression/async/fast-glob-current.ts

@@ -1,6 +1,6 @@
 import * as path from 'path';
 
-import * as glob from '../../../../index';
+import * as glob from '../../../..';
 import * as utils from '../../../utils';
 
 const options: glob.Options = {
@@ -15,7 +15,7 @@ glob(process.env.BENCHMARK_PATTERN as string, options)
 	.then((matches) => {
 		const memory = utils.getMemory();
 		const time = utils.timeEnd(timeStart);
-		const measures = utils.getMeasures(matches.length, time, memory);
+		const measures = utils.formatMeasures(matches.length, time, memory);
 
 		console.info(measures);
 	})