Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix braces pattern to support more than 2 choices #348

Merged
merged 3 commits into from
Jan 9, 2022
Merged

Fix braces pattern to support more than 2 choices #348

merged 3 commits into from
Jan 9, 2022

Conversation

amitdahan
Copy link
Contributor

What is the purpose of this pull request?

Closes #347

mrmlnc
mrmlnc requested changes Jan 9, 2022
View reviewed changes
Copy link
Owner

@mrmlnc mrmlnc left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the first contribution 🥇.

I left some suggestions to satisfy CI and eliminate future breakdowns.

src/utils/pattern.ts Outdated Show resolved Hide resolved
src/utils/pattern.spec.ts Show resolved Hide resolved
@amitdahan amitdahan requested a review from mrmlnc January 9, 2022 12:16
@mrmlnc mrmlnc merged commit ef3dcf1 into mrmlnc:master Jan 9, 2022
@amitdahan amitdahan deleted the fix-brace-pattern branch January 9, 2022 12:30
@amitdahan
Copy link
Contributor Author

Thanks for the super quick review & merge @mrmlnc ! 🚀

@myfreeer myfreeer mentioned this pull request Jan 10, 2022
Merged
@SherfeyInv SherfeyInv mentioned this pull request May 24, 2024
Merged
@rntvicente rntvicente mentioned this pull request May 24, 2024
Open
@abdulrahman305 abdulrahman305 mentioned this pull request Jul 4, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrmlnc mrmlnc mrmlnc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

{a,b,c} no longer considered a dynamic pattern
2 participants
@amitdahan @mrmlnc