ISSUE-190: Fix duplicate results for overlapping patterns due to a leading dot #402
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrmlnc
changed the title
mrmlnc
force-pushed
the
ISSUE-190_duplicates
branch
from
c8b0361 to
18aefc1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request?
This is a partial fix for #190. This pull request fix duplicate results for overlapping patterns due to a leading dot, as mentioned in #190 (comment).
What changes did you make? (Give an overview)
Do not use
path.normalizebecause it is an expensive function in terms of execution time. For 10_000 entries - 3ms; 100_000 – 10ms; 1_000_000 – 80ms.Uh, oh.
If there are issues on this topic, it will be necessary to consider the possibility of normalizing patterns at the task creation stage.